Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(directive): fixes incorrect example code #9635

Merged
merged 1 commit into from Jun 30, 2016
Merged

doc(directive): fixes incorrect example code #9635

merged 1 commit into from Jun 30, 2016

Conversation

ipinak
Copy link
Contributor

@ipinak ipinak commented Jun 27, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

  • Other... Please describe:
    The documentation of the directive was incorrect.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ipinak
Copy link
Contributor Author

ipinak commented Jun 27, 2016

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@vicb
Copy link
Contributor

vicb commented Jun 27, 2016

The commit author is set to ioannis.pinakoulakis [[ at ]] betssongroup.com, have you signed the CLA with this email ?

@ipinak
Copy link
Contributor Author

ipinak commented Jun 27, 2016

No, I will fix it. Can you remove the previous comment to avoid spam?

@ipinak
Copy link
Contributor Author

ipinak commented Jun 27, 2016

@vicb Should I close this PR and open a new one or change it?

@vicb
Copy link
Contributor

vicb commented Jun 28, 2016

Changing it is fine

@ipinak
Copy link
Contributor Author

ipinak commented Jun 28, 2016

@vicb it seems that the CLA bot does not catch the "I signed it!" comment. Do I need to do something else?

@vicb
Copy link
Contributor

vicb commented Jun 29, 2016

You probably haven't signed the CLA with the correct email

@googlebot
Copy link

CLAs look good, thanks!

@vicb vicb merged commit 8aa388d into angular:master Jun 30, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants